feat: adding possibility to pin information on preview area #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
spydon,
luanpotter,
renancaraujo,
tyemy and
wolfenrain
spydon
approved these changes
May 20, 2022
README.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| ## Example information | ||
|
|
||
| More than often, an example may not be intuitive enough and the user may be lost without some instruction on how to interact with it. To mitigate that, text information can be linked to an example to serve as a guide, or really to show any relevant information. |
README.md
Outdated
|
|
||
| This will present a small `i` icon on the side toolbar that once clicked will present the information to the user. | ||
|
|
||
| Dashbook also offers the possibility to directly show the information on the preview area, removing the necessity for the user to click on the icon. To do so, simple pass `true` to the `pinInfo` parameter. |
| @@ -18,3 +19,11 @@ extension WidgetTesterExtension on WidgetTester { | |||
| await pumpAndSettle(); | |||
| } | |||
| } | |||
|
|
|||
| extension CommonFindersX on CommonFinders { | |||
There was a problem hiding this comment.
Hah never seen X been used as a short form of Extension before, is this common? I think I'd prefer the word written out.
There was a problem hiding this comment.
Yeah, I didn't know either, but seems to be quite common.
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #70